CVS log for Amaya/annotlib/ANNOTlink.c

Up to [Public] / Amaya / annotlib

Request diff between arbitrary revisions

Keyword substitution: kv
Default branch: MAIN

Annotations are now displayed in the same window
Irene

Integration of Yusuke Ishii patches
Irene

When the user has a non-ISO login, annotations and transformations didn't
work.
Irene

Prevent a crash with annotations
(not done yet RDF parser doesn't manage internationalized URIs)
Irene

code cleaning + warning fixes
S. GULLY

Update the copyrigh.
Irene

bug fix: amaya didn't start when the Windows username was none latin (russian)
(todo : test this code on unix)
S. GULLY

Improve the management of mandatory attributes in the GTK version.
+ fix some bugs with the set of structure checking.
Irene

CSS: implementing value "list-item" for property "display", and
properties list-style-type and list-style-position.
VQ

Annotation icons were not displayed when their paths include spaces.
Irene

Removing _I18N_ within amaya and annotlib directories
Extending the copyright to 2004
Adding needed convertions utf-8 to the default charset.
Irene

JK: Changes for opening multiple bookmark files (temp. disabled
while fixing some model things)

This is the Amaya C++ version : ie amaya uses now g++ (c++ version of gcc)

WARNING:
Before compilation do :
    - On debian just install g++ : "apt-get install g++"
    - A cvs update into libwww directory because there is a expat header to update.
    - "rm -rf *"
    - "../configure [options...]"

S. GULLY

Use better practices; 'return TRUE;' instead of 'return 1;'
RRS

Avoid an access violation in ANNOT_InitDocumentMeta when a reply is
returned from the server without an inReplyTo property.  The code was
assuming that if there was no inReplyTo property then there must have
been an annotates property (thus source_url was non-NULL).  This fix
is more general; if the server returns any annotations that do not
annotate the current document, these annotations are now ignored rather
than assuming all returned annotations annotate the current document.
RRS

JK: The XPointer XPath expression was broken for embeeded dl lists.

JK: Make annotations work with generic XML documents. N.B.,
we still need to add NS to XPointers to be 100% compliant.

JK: if a document had some annotations, they were not shown after doing
a synchronize.

JK: The dynamic icons were not shown with the Raptor version because
the $THOTDIR and $APP_HOME substitutions didn't work there (a problem
with the base_uri subst. in ANNOTschemas.c.

JK: Fixes to many bugs related to Annots on Annots and replies... fixes
confusions with the annot_url and body_url for some operations.

JK: A small bug fix for the current BIG bug.
Doesn't solve yet all the problems

JK: Fixing the link to source document in annots on annots and replies.
FIxing the change of reply type on remote annotations.

Support file: URIs for the usesIcon property on an annotation type.
For convenience of installation, a non-file: name starting with
$THOTDIR or $APP_HOME will be accepted and the corresponding ENVVAR
will be expanded in the string.  This corresponds to the example in
the sample config/typeIcon.rdf file.  Uncomment the last line of
config/annot.schemas to try this yourself.
RRS

JK: The pencil icon appeared at the end of some range selections even if it
wasn't just a caret selection at the end of a line.

JK: There was a one character offset when splitting a text to
insert an annotation icon.

Annotea: The annotation icon was not displayed when annotating within
         a <pre>.
VQ

JK: Putting all unstable MIME types into amaya.h (see the bottom of the file

Bug fix: there was a confusion between utf-16 and utf-8
Irene

MathML + I18N: handling UTF16 characters in the parsing and editing
               functions for MathML.
VQ.

JK: Fixing a memory leak and a bad initialization detected by insure.

Resolving conflicts with the new notion of script.
Irene

JK: Because of a wrong simplification, the annotation icon was not being shown
inside PREs.

iI18N version
Irene

JK: Fixing compilation bugs when compiling without ANNOT_ON_ANNOT
(for Martin)

JK: Xmas present commit for Ralph:
Update the annotation icons when changing the type (you must save the annotation
to make the change effective).

JK: Amaya would crash when making a local annotation + a local reply, then
closing the reply + reloading the annotations.
Enhanced the code to detect if an annotation is already downloaded

Use subtypes for Reply that are subclasses of thread#Reply, not of
annotation-ns#Annotation.  This also adds a thot.rc variable
REPLY_DEFAULT_TYPE (parallel to ANNOT_DEFAULT_TYPE) so the user can
configure the type for new replies.

JK: Posting an annotation that had local replies or annotations attached to it
didn't update the local metadata to point to the new URL.
The reverse link from the metadata "source_doc" didn't work on annots on
annots.

JK: Annotation replies bug fixes, enhancements.
Things missing: sort the threads by date (sorted by reply to done)
Update the local annotations annotates and replies-to info after a post.
UI: show annotations in same window when browsing.

Protect dynamic icons in the case that we don't recognize a type from
an Annotea service.

JK: Removing compiler warnings when compiling without threads.
Saving annot->author and annot->title using UTF-8 (plus some untested
code for I18N for the same cases).

JK: removing compiler warnings

JK: Fixing compiler warnings. Adding UTF8 support for document title +
author metadata fields.

Add support for specifying annotation icon based on annotation type.

JK: Reloading an annotation with threads resulted in a duplication of
the thread items.

JK: Rewrote the reload behavior of annotations that have threads to have
an homogeneous behavior. Activated the close document X button so that
all resources are freed. Fixed related memory bugs. Changed the way that
threads are built in the annot window to take into account the server
download.

JK: Another compilation typo fix

JK: Hopefully, fixed the thread and annot/annot confusion bugs.
Some minor code cleaning.

JK: misplaced #else

JK: Several annotation/annotation and thread bug fixes (mostly for local
annotations).

JK: removing a warning

JK: Preparing the work for adding different annotation icons

I18N stuff + Annotation icons
Irene

Renaming GraphML by SVG
Don't forget to relaunch "../configure", "make clean", "make depend"

Irene

JK: A patch for uniformizing the use of file:// regardless of the platform.
This should fix up bugs we had when we wrongly added the file: prefix without
converting the rest of the URL under Windows platform. The patch should be
backwards compatible with existing annotations.
New URLs under Windows will now read: file:///drive:path.

JK: Removing warnings

JK: Unicode cleaning

JK: Unicode cleaning

JK: Annotation threads. Made reload of an annotation doc + threads work.
Now showing the title of annotation + author's name + last modif. date
in each thread item. Make new thread items be added at the end of the
thread, rather than as the first child (still needs work to sort the
threads). Make selection work on the desc item, rather than on the
thread item. Some bug fixes.

JK: Annot threads: removed the pencil icon for annotations. Selection
now works from the thread items. Changed the thread view to say "Replies",
some other fixes.

JK: Trying to hide the reply-to links

JK: Annot threads. Now showing the title of the annotations in the thread.
Reduced the thread indentation. Some bug fixes too.

JK: Allow to add a reply on any window, not just doc window 2.

JK: Saved threads can now be reloaded.

JK: Disabling the structure checkmode when adding the XLink element
in MathML and SVG trees.

JK: Thread changes... now locally saving and downloading annotations
(in progress).

Unicode stuff + code clean up
Irene

JK: Syncing the annotlib with Vincent's last commit

Removing the macro TEXT ()
Irene

JK: Fixing compiler warnings
Annotlib: code cleaning (rewrite of all the include statements + use of
annotlib.h)
Changed the Amaya version and date.

JK: Annotations of Table, THead, TBody, Tfoot elements.
New function for memorizing an XPointer.
New functions for re-assigning annotations to the value of a memorized
XPointer or to the current selection (work on progress).

JK: When making a new annotation, we first try to compute the XPointer.
If this operation fails, we don't open the annotation window anymore.
Previously, we always opened the annotation window.

JK: Exception for annotating <IMG> elements

JK: The (X)HTML S schema didn't allow to put the Annot element as a sibling
of a li or as a first child of a li/ul. We now search the first pseudo
paragraph and add it there.

JK: fixed the problems when annotating local file names which have spaces,
or when Amaya is stored in a directory with spaces (Windows)

JK: Removed all the compiler warnings that appear when compiling with
-Wall and -O2.
The remote raise source_doc and delete callbacks weren't checking the
return status code.

JK: The filters were showing the invisible and orphan annotations.
Many related bugs solved, some few remaining.

JK: Rewrote the annot filters functionality so that they are displayed
automatically. New three state indicator "visible, hidden, partially visible".
Some code cleaning tasks need to be done yet (re AnnotDelete).

JK: AnnotFilter_update... new function by ralph

Establish a default annotation type by searching the subclasses for one
named '...Comment'.  Let the user change this through a new resource
ANNOT_DEFAULT_TYPE, which can be either a full URI for a Class or the
localname part (e.g. 'Advice') which will then be searched in the schema.
RRS

JK: Trying to put the pencil icon in a nicer place when annotating paragraphs,
math, etc.

Merge exp_AnnotAuthUser branch into main branch.  This will display three
additional fields in the annotation metadata if the server supplies them,
else nothing will display.
RRS

Experimental support for displaying authenticated user information
from an Annotea service.  This adds three fields to the annotation
metadata and changes some interfaces in ANNOTschema.  This is
checked-in to a branch tagged exp_AnnotAuthUser so that Jose can
look it over and decide whether to merge it.
RRS

Capture the namespace name of the annotation schema from annot.schemas.
Relocate all other hard-coded namespace names to annotlib.h to make
future maintenance easier.

JK: Added a popup message box to say there were orphan annotations.
I don't like it too much, as the popup may appear once per annotation server.
Shall we just toggle a menu entry instead?

JK: There was a bug with the display mode, which had an effect on background
images, among other things.

JK: Dealing with orphan annotations.
For delete annotation, memorizing the last selected annotation by document
(rather than globally).
Added a call to StopTransfer when freeing the resources of an annotation.

JK: New function: AnnotateDocument

Mark orphanned annotations (those whose context XPointer no longer
selects an existing element) and bodyless annotations and write
a log of these in APP_TMPDIR.  This code is on a branch tagged
exp_AnnotErrLog for purposes of concurrent development.
RRS

JK: Handling of the stop button (in progress)
Better memorization of the last selected annotation, for the delete
button (in progress)
This is an early commit so that I can send a bug report.

JK: turn off the display mode while adding annotation icons to the
document (to keep it from flashing)

Take care not to free RDF resources when freeing the annotation
filter lists.

Add ANNOT_SCHEMA resource to permit identifying the location of the
annotation schema file, including a local file cached copy.  Create
such a locally cached copy in the config directory.

JK: The annotation is now placed as the first child of MathML and SVG
fragments.
Changes so that we can annotate a single MathML/SVG documents.

JK: If the user clicked on the reverse link from the annotation to the
soure doc, and if the annotation was stored locally, the annotated text
wasn't being selected.
Code simplification: moved all the code in the diverse functions that
were concatenating file:// to a URL to ANNOT_MakeFileURL.

JK: Now using an ID attribute defined in XLink.S. We couldn't use the
HTML ID attribute for annotations, because of exports. T doesn't allow to
create a rule between schemas.
The HTML.[STP] files don't contain any annotation related rules now.

JK: Bug fixes/enhancements to the remote protocols
Using now a specific anotation element (XLink, declared in XLink.S),
instead of piggy-backing on an HREF one (with the IsAnnotation attribute).
This allows to insert annotations anywhere on a document, without worrying
about the DTD and other goodies.

Make local filters work again.  API change to AnnotFilter_add.

JK: Making a new annotation without loading the local ones would erase
the previous local annotations.
Fixes so that the filters are updated after a delete

Use 'Comment' rather than (undefined) 'comment' for default annotation type.
Fix bug when updating local annotation index that caused "#" to be replicated
in annotation type.
Fix display of annotation type that is not from the default schema.
Preliminary support for better selection of annotation type.

JK: Update the local master index only for local annotations.
Code cleaning: removed all the non-used legacy functions.

JK: preparing the work for the remote delete.
Bug fix: the annot.index wasn't being updated.

JK: Delete of local annotations

JK: Fixed the bug introduced by the reverse linking mechanism and the
changes in the handling of "/".
Some initial code for deleting annotations.

JK: A simple click on the pencil icon selects the annotated text,
a double click opens the annotation window.
Code cleanup.

JK: Code cleaning.
If the user clicks on the source doc link, the annotated text is highlighted.

JK: Variable name cleaning
s/parserContext/XPointerContext/

JK: Preparing the work for using the Save/Post buttons in the new way.
These changes are for changing the reverse link in the source document
when doing a POST of a local annotation. We also remove the local annotation.
To be done:
Clean the annotation index and the metadata related to a posted annotation.

JK: First try at adding the pencil next to what was annotated.
It still doesn't work when trying to add it at the beginning of a paragraph or
before an element (rather than a text content).

JK: Using XPointer in the context, instead of the Amaya labels

Don't crash when there is no body URL returned.

JK: diverse bug fixes concerning the confusion between annot_url and
body_url.

JK and RRS : Safeguard commit before the demo
- New Timinificator easter egg
- Added an active reverse link to the document (a problem to jump to the
- name anchor seems to remain)
- Added a menu for changing the annotation types
- temporary hack to add a default type if it's missing
- we're now able to retrieve the body of a remote annotation.

When creating a new annotation we don't have a URL for it so we can't
add the server to the filter list.  We could look ahead and add the
POST server, maybe.  Just protect from segv for now.

JK: In the annotfilter, the author name is now shown as
author@annotation-server. Changed the selection logic. Enough for the demo,
but more work needs to be done in the interface.

JK: new AnnotFilter memory cleanup functions, called when closing, changing
documents.

JK: Added the BY_SERVER local annotation filter

JK: more work on the local filter. Added a * to say that an entry is
shown/hidden. Showing only one entry item even if it exists many times.
More work to be done yet!

RRS: fix parseType value to conform to RDF.  Maintain file:// in the
annot source_url consistently when annotating local resources.

JK: connected the Annotation configuration menu.
Added code to be able to consult n annotation servers.
Some bugs and memory leak changes.

RRS: complete a round-trip with the annotation database.
This requires the fixed annotate CGI; rev 1.24
Add the new annotation to the list when POSTing after the first one.
Update the annot struct from the server's reply after POST.
Introduce LINK_RemoveLinkFromSource (unfinished; need to construct annotName)
Introduce List_rem, Annot_free

RRS: Always add new annotations to the document list even when there
are already some annotations.

RRS: This now round-trips with the server successfully.  Shouldn't have
to mung the URI that the server gives us back for the annotation, however;
fix this when the server gets fixed.

JK: working on the last steps... reading an annotation from the server.

JK: Support for the last modified date, progress in reading from the RDF
dbase.. Next step, following a link to something stored there.

JK: Adding a custom query menu, and a last modified entry.

Ralph Swick: Big code cleanup, various enhancements, some Jose's bugs left

JK: code cleanup, preparing the query to the RDF server.

JK: suporting RDF on the locally stored annotations

JK: integrating a tree-less  annotation parser built on top of expat.
It compiles, but annotations are broken for the moment.
Changing the local annotation format to RDF too.

JK: Changes for taking into account the unicodification of Amaya
(work under progress).
Now using NormalizeFile to deal with the file: URLs.

JK: fixed the annotation Makefile dependencies
    new options and changes from the MIT annot meeting.
    Moved all the annot options to a specific menu.

JK: integrating the new annotation schemas

Some warning fixes, detected while compiling under Windows

JK: moved the annot stuff from the amaya directory. Made it compile as
libannot.a