Selectors API Disposition of Comments

Issues are marked as follows:

REJECTED
reviewer's comment was rejected, but reviewer didn't respond
NOT APPLICABLE
Due to other changes, the reviewers comment was no longer applicable
AGREED
reviewer's comment was accepted, but reviewer didn't respond
PENDING FURTHER COMMENT
reviewer needs to comment further before issue can be addressed
CLOSED BY REVIEWER
reviewer explicitly closed the issue without disagreement
POTENTIAL FORMAL OBJECTION
reviewer disagreed with response once, but did not follow up
FORMAL OBJECTION
reviewer disagreed with all responses

1. [selectors-api] Editorial

By: David Håsäther (hasather@gmail.com)

Summary: Editorial corrections.

AGREED

2. Selectors API comments: section 1.1

By: Boris Zbarsky (bzbarsky@MIT.EDU)

Summary: Error in script example

AGREED

3. Selectors API comments: section 1.2.1

By: Boris Zbarsky (bzbarsky@MIT.EDU)

Summary: Suggestion to rephrase some text in Terminology and Conventions

AGREED

4. [selectors-api] Selectors API comments: section 2

By: Boris Zbarsky (bzbarsky@MIT.EDU)

Summary: Clarification of DOM3Core reference

Status: Edited the paragraph to make the references more clear.

AGREED

5. [selectors-api] Selectors API comments: section 2

By: Boris Zbarsky (bzbarsky@MIT.EDU)

Summary: Define which IDL syntax is being used.

Status: Needs research into DOM Bindings spec.

AGREED

6. [selectors-api] Selectors API comments: section 2

By: Boris Zbarsky (bzbarsky@MIT.EDU)

Summary: Language bindings

Status: NSResolver removed, no function overloading, and so no longer relevant

NOT APPLICABLE

7. [selectors-api] Selectors API comments: section 2

By: Boris Zbarsky (bzbarsky@MIT.EDU)

Summary: Rephrase processing requirements for APIs

Status: Modified based on suggestions.

AGREED

8. [selectors-api] Selectors API comments: section 2

By: Boris Zbarsky (bzbarsky@MIT.EDU)

Summary: Clarify the requirements to use the NSResolver

Status: Edited text to more clearly reference requirements.

CLOSED BY REVIEWER

9. [selectors-api] Selectors API comments: section 2

By: Boris Zbarsky (bzbarsky@MIT.EDU)

Summary: ECMAScript authors using a Function in place of an Object for NSResolver

Status: Defined that ECMAScript implementations must support both functions and objects.

CLOSED BY REVIEWER

10. [selectors-api] Selectors API comments: section 2

By: Boris Zbarsky (bzbarsky@MIT.EDU)

Summary: Refer to "callers" or "conforming applications" instead of "authors"

CLOSED BY REVIEWER

11. [selectors-api] Selectors API comments: section 2

By: Boris Zbarsky (bzbarsky@MIT.EDU)

Summary: Refer to "implementation" instead of "user agent"

CLOSED BY REVIEWER

12. [selectors-api] Selectors API comments: section 2

By: Boris Zbarsky (bzbarsky@MIT.EDU)

Summary: Rephrase requirements for handling namespace prefixes

Status: Updated spec with suggested text.

CLOSED BY REVIEWER

13. [selectors-api] Selectors API comments: section 2

By: Boris Zbarsky (bzbarsky@MIT.EDU)

Summary: Define what an invalid selector is

Status: Referred to definition in Selectors.

AGREED

14. [selectors-api] Selectors API comments: section 2

By: Boris Zbarsky (bzbarsky@MIT.EDU)

Summary: Suggested requirement for UA to support same set of selectors as in CSS

Status: Added SHOULD level requirement to spec, but allowed for exceptions.

AGREED

15. [selectors-api] Selectors API comments: section 2

By: Boris Zbarsky (bzbarsky@MIT.EDU)

Summary: Define requirements for processing selector group

Status: Updated spec to refer to Selectors grammar.

CLOSED BY REVIEWER

16. [selectors-api] Selectors API comments: section 2

By: Boris Zbarsky (bzbarsky@MIT.EDU)

Summary: Ambiguous note about default namespace URI not needing to be defined

Status: Rephrased note to be more clear.

CLOSED BY REVIEWER

17. [selectors-api] Selectors API comments: section 2

By: Boris Zbarsky (bzbarsky@MIT.EDU)

Summary: Purpose of note about pseudo-elements is unclear

Status: Moved and rephrased as an advisory to authors about the use of pseudo-elements.

CLOSED BY REVIEWER

18. [selectors-api] Selectors API comments: section 2

By: Boris Zbarsky (bzbarsky@MIT.EDU)

Summary: Fix grammar of example text

Status: Updated spec with suggested text.

CLOSED BY REVIEWER

19. [selectors-api] Selectors API comments: section 2.1

By: Boris Zbarsky (bzbarsky@MIT.EDU)

Summary: efine expected behaviour of NSResolver for all possible input

Status: Rewrote conformance requirements for it.

CLOSED BY REVIEWER

20. [selectors-api] Selectors API comments: section 2.1

By: Boris Zbarsky (bzbarsky@MIT.EDU)

Summary: Grammatical issue with conformance requirement.

CLOSED BY REVIEWER

21. [selectors-api] Selectors API comments: section 2.1

By: Boris Zbarsky (bzbarsky@MIT.EDU)

Summary: Define what "similar constructs" means in context

Status: Removed the unnecessary phrase from the spec.

CLOSED BY REVIEWER

22. [selectors-api] Selectors API comments: section 2.1

By: Boris Zbarsky (bzbarsky@MIT.EDU)

Summary: Define requirements to handle NSResover as an ECMAScript Function

CLOSED BY REVIEWER

23. [selectors-api] Selectors API comments: section 2.1

By: Boris Zbarsky (bzbarsky@MIT.EDU)

Summary: Define requirements to handle non-string values

CLOSED BY REVIEWER

24. [selectors-api] Selectors API comments: section 2.1

By: Boris Zbarsky (bzbarsky@MIT.EDU)

Summary: Explain different handling of empty string for prefixes and default namespace

Status: Explained, no change to spec.

CLOSED BY REVIEWER

25. [selectors-api] Selectors API comments: section 2.1

By: Boris Zbarsky (bzbarsky@MIT.EDU)

Summary: Refer to "callers" instead of "user agents"

Status: Resolved as part of comment 11.

CLOSED BY REVIEWER

26. [selectors-api] Selectors API comments: section 2.1

By: Boris Zbarsky (bzbarsky@MIT.EDU)

Summary: Typo in "insensitive"

CLOSED BY REVIEWER

27. Best practice in HTML wellformed documents

By: Diego La Monica (IWA/HWG) (d.lamonica@webprofession.com)

Summary: Use XHTML syntax for example

Status: Rejected on technical grounds.

REJECTED

28. [selectors-api] Last-Call no-comment and thanks.

By: Al Gilman (Alfred.S.Gilman@IEEE.org)

Summary: Praise and worship of the spec :-)

Status: No action required.

CLOSED BY REVIEWER

29. [selectors-api]

By: Steven Pemberton (steven.pemberton@cwi.nl)

Summary: Clarify security considerations

Status: Initally attempted to rephrase, but ended up removing it along with the removal of NSResolver.

NOT APPLICABLE

30. Re: [selectors-api]

By: Boris Zbarsky (bzbarsky@MIT.EDU)

Summary: Define requirements for dealing with hostile behaviour from NSResolver

Status: NSResolver was removed, no longer relevant

NOT APPLICABLE

31. [selectors-api] What DOM feature "Selectors API" belongs to?

By: Sergey (castonet@yahoo.co.uk)

Summary: Add feature string for hasFeature()

Status: Added mandatory feature string

AGREED

32. Re: [selectors-api] What DOM feature "Selectors API" belongs to?

By: Sam Weinig (weinig@apple.com)

Summary: Change StaticNodeList to NodeList

Status: Changed to match existing implementation.

AGREED

33. [selectors-api] NSResolver and xml:* attributes (xml:id, xml:lang, xml:base, xml:space)

By: Sergey Ilinsky (castonet@yahoo.co.uk)

Summary: Predefine xml and xmlns prefixes for selectors

Status: Rejected on technical grounds.

REJECTED

34. [selectors-api] Minor formatting nit

By: Boris Zbarsky (bzbarsky@MIT.EDU)

Summary: Fix incorrect markup

AGREED

35.

Summary: Clarify case sensitivity of namespace prefixes

Status: Made case sensitivity more explicit, fixed examples.

AGREED

36.

Summary: If case insensitive, require Unicode Case Folding for namespace prefixes

Status: NSResolver was removed, no longer relevant

NOT APPLICABLE

37.

Summary: Require Unicode Normalisation NFC

Status: Rejected due to incompatibility with other existing features and increased complexity for authors.

REJECTED

38. [selectors-api] No comments from CSS WG

By: Bert Bos (bert@w3.org)

Summary: No comment from CSS WG

Status: No response.

CLOSED BY REVIEWER

39. [selectors-api] Why have two identical differently named interfaces?

By: Boris Zbarsky (bzbarsky@MIT.EDU)

Summary: Change to single NodeSelector interface

CLOSED BY REVIEWER

40. Re: [selectors-api] Why have two identical differently named interfaces?

By: liorean (liorean@gmail.com)

Summary: Introduce a element rooted selectors (:scope or similar)

Status: Out of scope, but can be considered for future.

REJECTED

41. [selectors-api] Why no querySelector(All) on DocumentFragments?

By: Boris Zbarsky (bzbarsky@MIT.EDU)

Summary: Support the interface to DocumentFragments

AGREED

42. Re: [selectors-api] Why have two identical differently named interfaces?

By: liorean (liorean@gmail.com)

Summary: Support the interface on Entity and EntityReference objects

Status: The interfaces have poor support in existing UAs, adding more to them would not help.

REJECTED

43. Re: [selectors-api] Extended Attribute [NoNull] in the IDL (was: Why have two identical differently named interfaces?)

By: Lachlan Hunt (lachlan.hunt@lachy.id.au)

Summary: Define how to handle null and undefined parameters

CLOSED BY REVIEWER

44. [selectors-api] NSResolver question: non-String returns

By: Boris Zbarsky (bzbarsky@MIT.EDU)

Summary: Stringify any object returned by NSResolver

Status: Spec already matched desired behaviour, no change necessary.

AGREED

45. [selectors-api] Handling :link and :visited Pseudo Classes

By: Lachlan Hunt (lachlan.hunt@lachy.id.au)

Summary: Clarify handling of :link and :visited pseudo classes

CLOSED BY REVIEWER

46. Re: [selectors-api] Handling :link and :visited Pseudo Classes

By: Bjoern Hoehrmann (derhoermi@gmx.net)

Summary: Define how to handle leading and trailing whitespace

AGREED

49. Behavior of querySelector/querySelectorAll with |div and *|div

By: Sam Weinig (weinig@apple.com)

Summary: Define behaviour of |div and *|div

AGREED

50. Selectors API and [Null] / [Undefined]

By: Anne van Kesteren (annevk@opera.com)

Summary: Remove raises clause from IDL

AGREED

51. [selectors-api] some doubts

By: João Eiras (joao.eiras@gmail.com)

Summary: Several questions about the API

Status: No spec changes requested

CLOSED BY REVIEWER

52. [selectors-api] Clarification about ElementSelector.querySelectorAll's scope

By: Kartikaya Gupta (kagupta@rim.com)

Summary: Another question about the API

Status: No spec changes requested

CLOSED BY REVIEWER

53. [selectors-api] Proposal to Drop NSResolver from Selectors API v1

By: Lachlan Hunt (lachlan.hunt@lachy.id.au)

Summary: Remove or replace NSResolver with a new, less problematic solution

Status: NSResolver has been removed, could be considered for a future version of the spec

CLOSED BY REVIEWER

54. [selectors-api] NSResolver moving nodes between documents

By: Boris Zbarsky (bzbarsky@MIT.EDU)

Summary: NSResolver moving nodes between documents

Status: NSResolver was removed, no longer relevant

NOT APPLICABLE

55. Re: [selectors-api] NSResolver moving nodes between documents

By: Boris Zbarsky (bzbarsky@MIT.EDU)

Summary: Allow for security exceptions to be thrown

AGREED

56. [selectors-api] Why does the default namespace have to be resolved?

By: Boris Zbarsky (bzbarsky@MIT.EDU)

Summary: Why does the default namespace have to be resolved?

Status: NSResolver was removed, no longer relevant

NOT APPLICABLE

57. [selectors-api] Return value of lookupNamespaceURI

By: Boris Zbarsky (bzbarsky@MIT.EDU)

Summary: Fix IDL to properly indicate return value of lookupNamespaceURI

Status: NSResolver was removed, no longer relevant

NOT APPLICABLE

58. [selectors-api] Why null as opposed to empty string (or either one) to resolve default namespace

By: Boris Zbarsky (bzbarsky@MIT.EDU)

Summary: Should parameter for resolving the default namespace be null or ""

Status: NSResolver was removed, no longer relevant

NOT APPLICABLE

59. [SelectorsAPI] Thoughts on querySelectorAll

By: John Resig (jresig@mozilla.com)

Summary: Scope all selectors within the chain to match only child elements

Status: The proposal for the :scope/:context pseudo-class is a more appropriate solution

REJECTED

60. [SelectorsAPI] Thoughts on querySelectorAll

By: John Resig (jresig@mozilla.com)

Summary: Combinator rooted queries

Status: Introducing :scope/:context partially addresses this problem, however may be considered for v2

REJECTED

61. [SelectorsAPI] Thoughts on querySelectorAll

By: John Resig (jresig@mozilla.com)

Summary: Provide more specific error diagnosis information

REJECTED

62. [selectors-api] Typo in Example

By: Gavin Kistner (gavin@phrogz.net)

Summary: Typo in example

AGREED

63. [selectors-api] Liveness versus NodeList

By: Gavin Kistner (gavin@phrogz.net)

Summary: Issue about the liveness of NodeLists

Status: Clarified the intent and effect of the spec, no change required

REJECTED

64. [selectors-api] First element example

By: Gavin Kistner (gavin@phrogz.net)

Summary: Clarify example to make it clear that the order of selectors used doesn't matter.

AGREED

65. [selectors-api] Matching subtrees or not

By: Gavin Kistner (gavin@phrogz.net)

Summary: Fix example in regards to subtree matching

Status: Example was correct, explained the misunderstanding to the reviewer.

REJECTED

66. [selectors-api] Names of querySelector() and querySelectorAll() methods

By: Gavin Kistner (gavin@phrogz.net)

Summary: Rename methods again

Status: Current names already have WG consensus.

REJECTED

67. [Selectors-API] IDL namespace

By: Kartikaya Gupta (lists.webapps@stakface.com)

Summary: Define in which Java module this API belongs.

Status: Updated IDL

AGREED

68. [selectors-api] LCWD comments

By: Krzysztof Maczyński (1981km@gmail.com)

Summary: Change the term "context node" to something else

REJECTED

69. [selectors-api] LCWD comments

By: Krzysztof Maczyński (1981km@gmail.com)

Summary: Use various more appropriate terms

Status: Changed some of the terms

AGREED

71. [selectors-api] LCWD comments

By: Krzysztof Maczyński (1981km@gmail.com)

Summary: Claim about pseudo-element matching being changed by CSSWG

Status: Reviewer misunderstood the issue

REJECTED

72.

Summary: Revise Interoperability Considerations

AGREED

73. CSS WG comments on Selectors API

By: Daniel Glazman (daniel.glazman@disruptive-innovations.com)

Summary: CSS WG has no official comment

Status: Appreciated.

CLOSED BY REVIEWER

74. Re: Call for Consensus - Selectors Last Call

By: Kartikaya Gupta (lists.webapps@stakface.com)

Summary: Remove definition of scope element, which isn't used yet

Status: Removed

CLOSED BY REVIEWER

75. Re: Call for Consensus - Selectors Last Call

By: Sean Hogan (shogun70@westnet.com.au)

Summary: Introduce a matchesSelector() method

Status: Deferred to version 2.

REJECTED

76. Re: Call for Consensus - Selectors Last Call

By: Cameron McCormack (cam@mcc.id.au)

Summary: Editorial changes, remove redundant statment about null/undefined, update WebIDL ref.

CLOSED BY REVIEWER

77.

Summary: SVG WG Comments

Status: Agreed with or reached compromise on most changes, rejected a few

CLOSED BY REVIEWER

78.

Summary: Require normalisation or add a note about the issues involved to the spec

Status: This spec is the wrong place to address the issue. The CSS WG's Selectors spec is more appropriate

REJECTED